Add AccessHandles to spec #344
Conversation
|
Hi @mkruisselbrink , could you PTAL? It's still a draft, but some early feedback would be great! |
Co-authored-by: Thomas Steiner <tomac@google.com>
Co-authored-by: Thomas Steiner <tomac@google.com>
Co-authored-by: Thomas Steiner <tomac@google.com>
|
Could you rebase these commits against https://github.com/whatwg/fs and create the PR there? I'm willing to help with review. |
This PR removes the naming open question and updates the table of contents. Lately there hasn't been an active discussion on naming, nor consensus on a better scheme, so it seems like the right time to remove it in preparation for shipment.
* Fix drag and drop example Fixes #356 * Update index.bs
|
@annevk will do after filling in the last couple missing methods, thanks for the review offer! |
There was a problem hiding this comment.
Overall this looks really good. You have exactly the right spirit and approach to rigorously specifying things.
I left a ton of comments, but only a few of them are substantative (and I marked them as "Important"). The vast majority are about style issues.
And, I bet a lot of those style issues are preexisting ones with the spec, so if you followed my suggestions you'd be introducing some inconsistency. In that case, you should feel free to not fix them here, but instead file issues (either on whatwg/fs or on this repo) to clean them up later, at a lower priority.
|
I'm closing this PR in favor of continuing the review in whatwg/fs#21, please leave any feedback there! |
This draft PR adds AccessHandles to the spec. It's currently missing the content on all AccessHandle methods, as well as the logic that releases the lock once a WritableStream is closed.
Preview | Diff
Preview | Diff