Default FilePickerAcceptType.description to the empty string #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI the implementation is updated here: https://crrev.com/c/4638360 Although the IDL is changing, can you confirm that we don't need to go through any sort of launch process because it's not actually a web-exposed change? |
inexorabletash
approved these changes
Jun 23, 2023
|
Re: launch process - that's a question for the Chromium change. :) But yes, if it's not web-visible and the reviewers agree it's sufficiently tested etc, no process should be needed. |
SGTM |
github-actions bot
added a commit
that referenced
this pull request
Jun 23, 2023
… string (#423) This has no behavioral changes, since not specifying the description field currently behaves the same as if the description was specified as the empty string Fixes #422 SHA: d8f5556 Reason: push, by @a-sully Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Jul 12, 2023
… string (#423) This has no behavioral changes, since not specifying the description field currently behaves the same as if the description was specified as the empty string Fixes #422 SHA: d8f5556 Reason: push, by @a-sully Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Aug 7, 2023
This is a behavioral no-op, since not specifying the description field currently behaves the same as if the description was specified as the empty string. See WICG/file-system-access#423 Bug: N/A Change-Id: Id946d822e514d6633513b48c5bf7af0df8c7155c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4638360 Reviewed-by: Nathan Memmott <memmott@chromium.org> Commit-Queue: Nathan Memmott <memmott@chromium.org> Auto-Submit: Austin Sullivan <asully@chromium.org> Cr-Commit-Position: refs/heads/main@{#1180608}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has no behavioral changes, since not specifying the description field currently behaves the same as if the description was specified as the empty string
Fixes #422
Preview | Diff