Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add options to createWriter() to deal with atomic writes. #51

Merged
merged 4 commits into from
Jun 10, 2019
Merged

Add options to createWriter() to deal with atomic writes. #51

merged 4 commits into from
Jun 10, 2019

Commits on Jun 10, 2019

  1. Add options to createWriter() to deal with atomic writes. 

    This attempts to solve #37 by making it explicit that changes made to files
might not be reflected on disk until flush() or close() is called on the
writer.

This also introduces a "atomic" mode for FileSystemWriter where any changes
are written to a temporary file, and only on flush or close is that file
moved on top of the destination file. This should address #48.
    @mkruisselbrink
    mkruisselbrink committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    43c256f View commit details
    Browse the repository at this point in the history

  2. Remove flush() for now.

    @mkruisselbrink
    mkruisselbrink committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    e0016a6 View commit details
    Browse the repository at this point in the history

  3. Fix typo.

    @mkruisselbrink
    mkruisselbrink committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    d6c4bc5 View commit details
    Browse the repository at this point in the history

  4. Rename dictionary fields.

    @mkruisselbrink
    mkruisselbrink committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    539edf6 View commit details
    Browse the repository at this point in the history