IE11: ensure target.nodeName exists #197
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've seen a few cases where IE11 throws this error:
See full example on Sentry: https://sentry.io/share/issue/f02ceb35bf504436a21a60c08154341d/
The
e.target.nodeName
inonInitialPointerMove
isundefined
, so attempting to read it throws an error.This pull request adds an extra guard that checks if
nodeName
exists, before callingtoLowerCase()
.