Create tabbed-mode-explainer.md #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomayac
reviewed
May 17, 2022
There was a problem hiding this comment.
As the author of the Tabbed Application Mode article, I'm really excited about progress in this area. I have left a couple of comments and suggestions.
Co-authored-by: Thomas Steiner <tomac@google.com>
tomayac
reviewed
May 18, 2022
tomayac
reviewed
May 18, 2022
tomayac
reviewed
May 18, 2022
tomayac
reviewed
May 18, 2022
tomayac
reviewed
May 18, 2022
Co-authored-by: Thomas Steiner <tomac@google.com>
dmurph
approved these changes
May 27, 2022
| The proposed format makes it easy to add more fields to the `tab_strip` member in the future. | ||
|
|
||
| A possible extension to the home tab is a `scope` field. This could allow for the home tab to navigate within that scope, and only open links in new tabs that are outside the scope. | ||
|
|
There was a problem hiding this comment.
It would be nice if browsers could have a keyboard shortcut to navigate to the pinned tab. Technically Ctrl-0 on chromium goes to the first tab, and maybe this would work fine.
(not a comment, just a thought)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.