Add tabbed mode spec #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@loubrett Ready for you to look now. |
loubrett
reviewed
Mar 8, 2024
|
I just pushed a major rework. Still incomplete so don't re-review yet. |
Copy-pasted from Louise Brett's source doc. Need to clean up, linkify and edit.
Now there is just a single processing section at the h2 level.
Too numerous to list individual changes. A lot of moving around. Many additional details added, including: - List of invariants that must be followed (e.g. home tab never navigates out of home scope, regular tab never navigates into home scope). - Specifying that home tabs open at the start_url. - Properly defining within and outside of home scope terms. - Properly defining what happens when you click the new tab button.
Define a boolean condition first, rather than defining a set. Makes it more readable. Also exclude fragments (but not query).
…non-normatively, and just talk about it as an idea, not a formal term. Add a note about ignoring the fragment but not the query.
Do not use the at-risk string syntax. Add more detail about the default matching the query, or not.
Now, the three invariants are non-normative discussion of what is intended, rather than a hard rule. The normative logic elsewhere should speak for itself. This way, we do not need to formally find a concept of 'initial URL' and can just informally talk about documents that rewrite their URL.
|
@dmurph adding as editor. PTAL, thanks, and let me know if you want to discuss! |
loubrett
reviewed
Apr 23, 2024
dmurph
reviewed
Apr 23, 2024
Now has an explicit concept of "has a new tab button" (analogous to "has a home tab"). The parser algorithm no longer (accidentally) sets the new tab URL to the start URL if it is within home tab scope. Add a note clarifying why the new tab button is not allowed to be in home tab scope. Also note the start URL default, which is easy to miss as it is buried in the parser algorithm.
Done in consultation with dmurph and loubrett, to make the navigation rules much clearer and hook into the HTML navigable machinery.
dmurph
approved these changes
Apr 26, 2024
Thanks Dan. Yes, I mentioned this to you in a chat: we need to wait until w3c/csswg-drafts#7306 gets pushed out to the editor's draft, and then it will automatically resolve itself (because the definition of "display mode" was moved from CSS mediaqueries-5 to Manifest; Manifest updated right away, CSS did not). I don't know when that will be; it was last updated in May 2022, coming up to two years... Edit: filed an issue about this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on an earlier draft by @loubrett (Louise Brett).
Preview | Diff