Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should add appHistory.reload(), and probably subsume appHistory.navigate(options) #112

Closed
domenic opened this issue May 12, 2021 · 0 comments · Fixed by #118
Closed

Comments

@domenic
Copy link
Collaborator

domenic commented May 12, 2021

As part of #67, @jakearchibald, @annevk, @smaug---- and I were thinking about how to allow developers to express reloads with app history, so that they could stop using location.

You could currently do appHistory.navigate(appHistory.current.url), but this is not very explicit. Also, doing this fails to set the "reload-triggered navigation" flag which is visible to service workers, or set the navigationType visible to navigation timing.

So adding something like appHistory.reload({ state, info }) makes sense.

But then, once we have that, we probably don't need appHistory.navigate({ state, info }) anymore. Which is good, because that method was always a bit confusing.

domenic added a commit that referenced this issue May 20, 2021
Closes #112. Note that the behavior differs in that previously appHistory.navigate(options) would do a same-URL replace, which is subtly different from a reload in observable ways.

Some follow-up discussion in #117.
domenic added a commit that referenced this issue May 25, 2021
Closes #112. Note that the behavior differs in that previously appHistory.navigate(options) would do a same-URL replace, which is subtly different from a reload in observable ways.

Some follow-up discussion in #117.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant