Move URL/history updating out of respondWith() #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that if multiple event handlers are in place, appHistory.current and location.href only update after they all have finished. Part of #94.
natechapin
approved these changes
Apr 23, 2021
| @@ -464,6 +459,12 @@ An {{AppHistoryNavigateEvent}} also has an associated {{Promise}}-or-null <dfn f | |||
| 1. Let |result| be the result of [=dispatching=] |event| at |appHistory|. | |||
| 1. If [=this=]'s [=relevant global object=]'s [=Window/browsing context=] is null, then return false. | |||
| <p class="note">This can occurr if an event listener disconnected the <{iframe}> corresponding to [=this=]'s [=relevant global object=].</p> | |||
| 1. If |event|'s [=AppHistoryNavigateEvent/navigation action promise=] is non-null, then: | |||
There was a problem hiding this comment.
navigation action promise will only be non-null here if respondeWith() was called, right?
There was a problem hiding this comment.
Exactly, it's basically synonymous with that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that if multiple event handlers are in place, appHistory.current and location.href only update after they all have finished.
Part of #94.
Preview | Diff