Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial spec for appHistory.navigate() and event.destination #96

Merged
merged 24 commits into from
May 4, 2021
Merged

Initial spec for appHistory.navigate() and event.destination #96

merged 24 commits into from
May 4, 2021

Commits on Apr 15, 2021

  1. Basics

    @domenic
    domenic committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    fdbb045 View commit details
    Browse the repository at this point in the history

  2. Thread through navigateInfo

    @domenic
    domenic committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    3223ae6 View commit details
    Browse the repository at this point in the history

  3. Thread through the promise

    @domenic
    domenic committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    37f74d7 View commit details
    Browse the repository at this point in the history

  4. AbortError on preventDefault()

    @domenic
    domenic committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    b76e466 View commit details
    Browse the repository at this point in the history

  5. Note

    @domenic
    domenic committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    4de4990 View commit details
    Browse the repository at this point in the history

  6. Tweak domintro

    @domenic
    domenic committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    4fc89fe View commit details
    Browse the repository at this point in the history

  7. Tweaks

    @domenic
    domenic committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    8440db9 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2021

  1. Basic destination, no state yet

    @domenic
    domenic committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    88f0c61 View commit details
    Browse the repository at this point in the history

  2. Wire state through

    @domenic
    domenic committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    7497ae6 View commit details
    Browse the repository at this point in the history

  3. Eliminate extra destination URL field

    @domenic
    domenic committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    c179c21 View commit details
    Browse the repository at this point in the history

  4. Some tweaks

    @domenic
    domenic committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    a7f31ef View commit details
    Browse the repository at this point in the history

  5. Split firing into two algorithms with different inputs

    @domenic
    domenic committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    4252098 View commit details
    Browse the repository at this point in the history

  6. Add destination.sameDocument

    @domenic
    domenic committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    85cc13b View commit details
    Browse the repository at this point in the history

  7. Update explainer

    @domenic
    domenic committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    83d9b40 View commit details
    Browse the repository at this point in the history

  8. Move state setting 

    This has the impact of making appHistory.navigate("#foo", { state }) work instead of ignore the state (even when there's no navigate event handler)
    @domenic
    domenic committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    b627958 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2021

  1. Note serializable restriction

    @domenic
    domenic committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    444f000 View commit details
    Browse the repository at this point in the history

  2. Reorder and consolidate promise reactions

    @domenic
    domenic committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    eb95239 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2021

  1. Carry over state on fragment navigation

    @domenic
    domenic committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    47ebd3c View commit details
    Browse the repository at this point in the history

  2. Fix when state is set

    @domenic
    domenic committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    2e491b7 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into navigate-spec

    @domenic
    domenic committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    412b38f View commit details
    Browse the repository at this point in the history

  4. Centralize aborting

    @domenic
    domenic committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    bd28fdd View commit details
    Browse the repository at this point in the history

  5. Queue a microtask for the aborting so that it's similar timing to res… 

    …pondWith(Promise.reject())
    @domenic
    domenic committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    9ce06fd View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into navigate-spec 

    # Conflicts:
#	spec.bs
    @domenic
    domenic committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    0e596c0 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into navigate-spec 

    # Conflicts:
#	spec.bs
    @domenic
    domenic committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    2775e31 View commit details
    Browse the repository at this point in the history