Fire the load event for portals #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of #26.
lucasgadani
approved these changes
May 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #26. This does not yet take care of delaying the load event of the outer window.
Some things to note:
Iframes have an "iframe load in progress" flag which is set before and unset after firing the event. I guess this is to prevent a sort of infinite recursion? This didn't seem very necessary so I didn't copy it, but I might be wrong.
Iframes have a "mute iframe load" flag which is set by document.open(), and has some known spec bugs. This seems like legacy so we shouldn't copy it, I'm pretty sure.
Please let me know what you think of these points, as well as how well this matches the Chromium implementation.
Preview | Diff