Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HTML's "wait for timeout" #54

Merged
merged 1 commit into from
Feb 7, 2022
Merged

Conversation

domenic
Copy link
Collaborator

@domenic domenic commented Nov 19, 2021

This is on top of #53 since that's necessary to get the build working.

Don't merge until whatwg/html#7349 is merged, but review is appreciated. (Probably best to view a single commit at a time.)

@shaseley
Copy link
Collaborator

shaseley commented Feb 7, 2022

Coming back to this now that all of the dependencies have landed, I think this is probably good to go after a rebase? I think the only change is probably that the algorithm name changed (wait for timeout --> run steps after a timeout)?

This ensures delayed postTask()-scheduled tasks contribute to idle
deadline computation, and are automatically removed from consideration
on global destruction.
@domenic
Copy link
Collaborator Author

domenic commented Feb 7, 2022

Yep, seems to work! All rebased and updated.

Copy link
Collaborator

@shaseley shaseley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@shaseley shaseley merged commit be34190 into WICG:main Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants