first attempt at XHR spec update #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvorak42
reviewed
Jul 7, 2023
|
What I had in my mind was something very similar to what the spec has for fetch. Basically check whether |
dvorak42
approved these changes
Jul 10, 2023
jyasskin
reviewed
Jul 10, 2023
jyasskin
reviewed
Jul 10, 2023
spec.bs
Outdated
| Integration with XMLHttpRequest {#xhr} | ||
| ==================================== | ||
|
|
||
| An XMLHttpRequest has an associated {{PrivateToken}} object specifying the {{OperationType}} to execute against the request. |
There was a problem hiding this comment.
You need to use this field somewhere to inform the actual request. Is that a monkeypatch to https://xhr.spec.whatwg.org/#the-send()-method to fill in a new Request field?
There was a problem hiding this comment.
Added details for send() monkeypatch
Co-authored-by: Jeffrey Yasskin <jyasskin@gmail.com>
Co-authored-by: Jeffrey Yasskin <jyasskin@gmail.com>
Co-authored-by: Jeffrey Yasskin <jyasskin@gmail.com>
Co-authored-by: Jeffrey Yasskin <jyasskin@gmail.com>
Co-authored-by: Jeffrey Yasskin <jyasskin@gmail.com>
Co-authored-by: Jeffrey Yasskin <jyasskin@gmail.com>
jyasskin
approved these changes
Jul 12, 2023
Co-authored-by: Jeffrey Yasskin <jyasskin@gmail.com>
Co-authored-by: Jeffrey Yasskin <jyasskin@gmail.com>
Co-authored-by: Jeffrey Yasskin <jyasskin@gmail.com>
github-actions bot
added a commit
that referenced
this pull request
Jul 13, 2023
SHA: 1756871 Reason: push, by tim-huber Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to aykutbulut/trust-token-api
that referenced
this pull request
Jul 13, 2023
SHA: 1756871 Reason: push, by aykutbulut Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview | Diff