Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smact filter patch #146

Merged
merged 6 commits into from
Jul 14, 2023
Merged

Smact filter patch #146

merged 6 commits into from
Jul 14, 2023

Conversation

AntObi
Copy link
Collaborator

@AntObi AntObi commented Jul 14, 2023

Pull Request Template

Description

  • Reverted changes to the output of the smact_filter to make it compatible with multiprocessing.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

  • Ran test suite
  • Checked that smact_filter works with multiprocessing

Test Configuration:

  • Python version: 3.9
  • Operating System: WSL2(Ubuntu)

Reviewers

N/A

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Merging #146 (c17b32e) into master (574399b) will increase coverage by 0.20%.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##           master     #146      +/-   ##
==========================================
+ Coverage   72.64%   72.85%   +0.20%     
==========================================
  Files          24       24              
  Lines        1872     1879       +7     
==========================================
+ Hits         1360     1369       +9     
+ Misses        512      510       -2     
Impacted Files Coverage Δ
smact/screening.py 88.98% <66.66%> (+1.91%) ⬆️
smact/tests/test_core.py 100.00% <100.00%> (ø)

@AntObi AntObi merged commit aab9a93 into master Jul 14, 2023
12 checks passed
@AntObi AntObi deleted the smact_filter_patch branch July 14, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant