Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structure updates #154

Merged
merged 2 commits into from
Aug 23, 2023
Merged

Structure updates #154

merged 2 commits into from
Aug 23, 2023

Conversation

AntObi
Copy link
Collaborator

@AntObi AntObi commented Aug 23, 2023

Pull Request Template

Description

  • SmactStructures can now be made with pymatgen structures with predecorated oxidation states.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Test Configuration:

  • Python version: 3.9
  • Operating System: WSL2

Reviewers

N/A

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #154 (c68cb0d) into master (2bdeac6) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #154      +/-   ##
==========================================
- Coverage   72.96%   72.89%   -0.08%     
==========================================
  Files          24       24              
  Lines        1894     1896       +2     
==========================================
  Hits         1382     1382              
- Misses        512      514       +2     
Files Changed Coverage Δ
smact/structure_prediction/structure.py 70.14% <0.00%> (-0.71%) ⬇️

@AntObi AntObi merged commit a6005bd into master Aug 23, 2023
11 of 15 checks passed
@AntObi AntObi deleted the structure_updates branch August 23, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant