Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage and doc updates #88

Merged
merged 18 commits into from
Dec 22, 2022
Merged

Usage and doc updates #88

merged 18 commits into from
Dec 22, 2022

Conversation

AntObi
Copy link
Collaborator

@AntObi AntObi commented Dec 22, 2022

  • README.md has been updated to include badges which indicate the CI status, code style (black), PyPi version, dependencies status, and python versions compatible with SMACT
  • The classifiers in setup.py have been updated to mention the python versions and license for SMACT
  • Typing hints added in smact/_init__.py, oxidation_states.py and properties.py
  • Typing hints added in screening.py. smact_filter now outputs a list of namedtuples instead of a list of tuples
  • docstrings in doper.py have been updated
  • updated smact/dopant_prediction/__init__.py with a minimal description
  • Options are now available to determine how oxidation states are assigned to create smactStructures. They can be determined either using bond valence or using ICSD statistics.
  • Added a pull request template
  • Ran pre-commit on all files

@AntObi AntObi merged commit 98f4f2d into master Dec 22, 2022
@AntObi AntObi deleted the usage-and-doc-updates branch December 22, 2022 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant