Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a new method to deal with the build up of old tokens. #141

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mcondave
Copy link

@mcondave mcondave commented May 13, 2016

Before adding the "oauth1_access_..." token, revoke any existing tokens for the user/consumer pair so the user's profile isn't flooded with old access tokens that are no longer applicable.

Related to the following issues:

#134
#131

@kosso
Copy link
Contributor

kosso commented May 16, 2016

I tried this. And while it did clear out all the old access_tokens, I could not log in to my app, despite it leaving one behind.

@mcondave
Copy link
Author

@kosso Was an error message returned either on the client side or in your logs?

@kosso
Copy link
Contributor

kosso commented Oct 11, 2016

I've just tried this change again on 2.0-Beta15 and it appears to be working as expected now.

No more duplicate Application entries on the profile page from the same client.

Though, whether this is a desirable effect, I haven't quite decided.

eg: One 'universal' iOS client app installed on two devices (eg: an iPhone and an iPad).
Each time you logged in on one device, any stored token on the other device would be invalidated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants