Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code quality improvements #226

Merged
merged 21 commits into from
Nov 24, 2023
Merged

Code quality improvements #226

merged 21 commits into from
Nov 24, 2023

Conversation

jonnynews
Copy link
Contributor

@jonnynews jonnynews commented Nov 17, 2023 •
edited
Loading

This PR generally fixes bugs and issues in the codebase. Improves include.

  • Improved error handling and messaging.
  • Ensure all places that return WP_Error, call wp_die.
  • Delete access and request tokens on deletion of application.
  • Improve compatibility with PHP 8.
  • Remove deprecation warnings for WordPress.
  • Improve PHPDocs.

Fixes #223 #217
Closes #202

@jonnynews jonnynews marked this pull request as ready for review November 21, 2023 12:44
@jonnynews jonnynews changed the title Code improves and PHP 8.0 compat Code quality improvements Nov 24, 2023
@spacedmonkey spacedmonkey self-requested a review November 24, 2023 10:56
@spacedmonkey spacedmonkey merged commit e23038c into WP-API:master Nov 24, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey

Assignees

@jonnynews jonnynews

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PHP 8.0 warning thrown by normalize_parameters
2 participants
@jonnynews @spacedmonkey