Renaissance (partial rewrite) #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds description on the name.
|
Note: this will partially invalidate existing clients, as they now need a callback saved in the database to be used as the base for checking against. Already-issued access tokens will continue to work, but you won't be able to create new request tokens or authorize them. |
|
👍 Thanks. This works for me. I had to create a new consumer to get one of the old ones working again though. btw: Not too sure how to implement your workaround for #95 using WP_REST_Server in |
Function and redirect change
… the consumer name correctly.
… th with no left padding for some reason. Hardcoded some padding inline for now. Also included missing th element.
Fixed bug in Profile > Authorized Applications
|
It's go time! |
This was referenced Dec 7, 2015
Closed
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are tonnes of open issues here, and they need fixing. The best way to do this is hunkering down and doing them all at once by going back to the drawing board.
This fixes a tonne of the outstanding issues and adds a bit of polish. It's not done yet, but it's forward progress.