Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update adding-custom-endpoints.md #101

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update adding-custom-endpoints.md #101

wants to merge 1 commit into from

Conversation

abdul-alhasany
Copy link

Added a clarification for required property and empty values being allowed.

Added a clarification for required property and empty values being allowed.
@TimothyBJacobs
Copy link
Member

Thanks for the PR @kalimah-apps! I don't think this should be called out in an alert of its own, but rather alongside the required description.

@abdul-alhasany
Copy link
Author

I added it as an alert because it was not clear. I assumed required covers the length too. But as long as it is added then it should be fine.

@kadamwhite
Copy link
Contributor

@abdul-alhasany Hello there! It's been a while on this PR -- if you're still interested in seeing this change made, would you be able to update the patch? I agree with Timothy about making this a sub-bullet of the *required* argument description, instead of an alert.

Thank you

@kadamwhite kadamwhite added the /reference/ An issue with the schema-derived /reference/ documentation label Aug 31, 2023
@abdul-alhasany
Copy link
Author

@kadamwhite It has been a while and I have removed the branch that created this PR. I am not sure if I can update this patch. I might need to create a new PR with the proposed changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
/reference/ An issue with the schema-derived /reference/ documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants