Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync v1.2.2 changes to main branch #487

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Sync v1.2.2 changes to main branch #487

wants to merge 12 commits into from

Conversation

kadamwhite
Copy link
Collaborator

No description provided.

kadamwhite and others added 12 commits January 22, 2019 23:32
Changes since v1.1.2:

- **BREAKING**: The minimum supported node version is now v8.
- **BREAKING**: `._paging.total` and `._paging.totalPages` response properties are now returned as integers, not strings.
- Bundled route handlers are now available for new first-party endpoints in WordPress 5.0.
- The project now uses Jest and ESLint in place of Mocha, Chai, JSCS and JSHint. Thank you for your years of service, ["nyan" reporter](https://mochajs.org/#nyan)!
- Browser bundle size has been reduced.

Props @computamike.
- Fix issue where `li` was improperly declared as a dev-only dependency

props @el-lsan & @jerolan
@HoraceShmorace rightly comments that we have not made our conformance
to semver (or lack thereof) clear, and the Node support matrix change
in 1.2 constitutes an insufficiently-announced breaking change. This
commit updates the README and CHANGELOG to clarify that this library
will only run correctly on Node versions later than 8.2.1 `--harmony`,
not simply any version of Node v8.

Closes #419
- Fix route match error with WordPress 5.5
- Throw an error early when .file() is passed a Buffer without an accompanying name string

Props @socrates77, @cungminh2710 & @mvhirsch
Copy link

@jojonarte jojonarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants