Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post-social.php syntax issue #1885

Closed
rlambertsen opened this issue Mar 23, 2021 · 1 comment
Closed

Post-social.php syntax issue #1885

rlambertsen opened this issue Mar 23, 2021 · 1 comment
Assignees
Labels
Estimate: < 2 Hours priority: high Either blocks work on a priority-normal task or a solution here informs other work. status: in progress type: bug type: tech debt For necessary updates because code is old

Comments

@rlambertsen
Copy link
Collaborator

rlambertsen commented Mar 23, 2021

Using Wordpress 5.7
PHP 8.0.3
Largo 0.6.4

When I installed the theme for doc rewrite I came across this issue.

Opening any post would throw this error

Fatal error: Uncaught TypeError: implode(): Argument #2 ($array) must be of type ?array, string given in /Users/rylan/Desktop/sites/largo/wp-content/themes/largo/inc/post-social.php:174 Stack trace: #0 /Users/rylan/Desktop/sites/largo/wp-content/themes/largo/inc/post-social.php(174): implode(Array, '\n') #1 /Users/rylan/Desktop/sites/largo/wp-content/themes/largo/partials/content-single.php(22): largo_post_social_links() #2 /Users/rylan/Desktop/sites/largo/wp-includes/template.php(732): require('/Users/rylan/De...') #3 /Users/rylan/Desktop/sites/largo/wp-includes/template.php(676): load_template('/Users/rylan/De...', false, Array) #4 /Users/rylan/Desktop/sites/largo/wp-includes/general-template.php(204): locate_template(Array, true, false, Array) #5 /Users/rylan/Desktop/sites/largo/wp-content/themes/largo/single-one-column.php(26): get_template_part('partials/conten...', 'single') #6 /Users/rylan/Desktop/sites/largo/wp-includes/template.php(732): require('/Users/rylan/De...') #7 /Users/rylan/Desktop/sites/largo/wp-includes/template.php(676): load_template('/Users/rylan/De...', false, Array) #8 /Users/rylan/Desktop/sites/largo/wp-includes/general-template.php(204): locate_template(Array, true, false, Array) #9 /Users/rylan/Desktop/sites/largo/wp-content/themes/largo/single.php(8): get_template_part('single-one-colu...') #10 /Users/rylan/Desktop/sites/largo/wp-includes/template-loader.php(106): include('/Users/rylan/De...') #11 /Users/rylan/Desktop/sites/largo/wp-blog-header.php(19): require_once('/Users/rylan/De...') #12 /Users/rylan/Desktop/sites/largo/index.php(17): require('/Users/rylan/De...') #13 /Users/rylan/.composer/vendor/laravel/valet/server.php(219): require('/Users/rylan/De...') #14 {main} thrown in /Users/rylan/Desktop/sites/largo/wp-content/themes/largo/inc/post-social.php on line 174

$more_social_links_str = implode( $more_social_links, "\n" );

rlambertsen added a commit that referenced this issue Mar 24, 2021
…-social.php causing fatal error on all single post pages
@joshdarby joshdarby added Estimate: < 2 Hours priority: high Either blocks work on a priority-normal task or a solution here informs other work. status: in progress type: bug type: tech debt For necessary updates because code is old labels Mar 24, 2021
@rlambertsen
Copy link
Collaborator Author

closing as this PR fixes issue #1887

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Estimate: < 2 Hours priority: high Either blocks work on a priority-normal task or a solution here informs other work. status: in progress type: bug type: tech debt For necessary updates because code is old
Projects
None yet
Development

No branches or pull requests

2 participants