Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duplicate prominence terms in 0.4 #414

Closed
aschweigert opened this issue Feb 23, 2015 · 1 comment
Closed

duplicate prominence terms in 0.4 #414

aschweigert opened this issue Feb 23, 2015 · 1 comment
Assignees
Labels
priority: high Either blocks work on a priority-normal task or a solution here informs other work. type: bug
Milestone

Comments

@aschweigert
Copy link

This is true, as far as I can tell for all sites that have updated from 0.3 to 0.4.

Now that we made the prominence taxonomy "flat" instead of making "top story" a child of "homepage featured" there are duplicate terms that are confusing everyone, seeL

duplicate-terms

This is particularly a problem because the homepage layouts are using either the slug or the term name to get the featured posts in various contexts. We need to go through this much more carefully and make sure that:

a) duplicate terms are not created (and delete/rename terms as necessary)
b) all homepage layouts are getting the featured posts THE SAME WAY (either by slug or term name) so future updates will be less fraught

@aschweigert aschweigert added type: bug priority: high Either blocks work on a priority-normal task or a solution here informs other work. labels Feb 23, 2015
@aschweigert aschweigert added this to the 0.4.1 milestone Feb 23, 2015
@benlk
Copy link
Collaborator

benlk commented Mar 10, 2015

Are there any sites that are not experiencing this? I think they'd be ones using:

  • no homepage top option
  • Blog
  • Top Stories

If that's the case, then it's because we don't remove the previously-existing "Top Story" prominence and the slug is duplicated by the other layouts, which create a new prominence term when they're in use.

benlk added a commit that referenced this issue Mar 11, 2015
@aschweigert aschweigert modified the milestones: 0.4.1, 0.5 Mar 16, 2015
rnagle added a commit that referenced this issue Mar 17, 2015
Update functions for #414 and enabling series and landing pages if they were in use before
@rnagle rnagle closed this as completed Mar 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high Either blocks work on a priority-normal task or a solution here informs other work. type: bug
Projects
None yet
Development

No branches or pull requests

3 participants