Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recommended posts widget styling is broken #722

Closed
aschweigert opened this issue May 19, 2015 · 8 comments
Closed

recommended posts widget styling is broken #722

aschweigert opened this issue May 19, 2015 · 8 comments
Assignees
Labels
priority: normal Must be completed before release of this version of plugin. status: in progress type: bug

Comments

@aschweigert
Copy link

see: http://jira.inn.org/browse/IW-19

even though that widget is deprecated, until we actually remove it it should at least have some basic styling (particularly considering it's in the default stack of widgets added to new sites when largo is installed)

@aschweigert aschweigert added type: bug priority: normal Must be completed before release of this version of plugin. labels May 19, 2015
@aschweigert aschweigert added this to the 0.5.1 milestone May 19, 2015
@benlk
Copy link
Collaborator

benlk commented May 22, 2015

If it's in the default stack of widgets added and it's deprecated, should we remove it from the default widgets?

@wjhdev
Copy link

wjhdev commented Jun 1, 2015

A step further: Any reason not to remove this widget entirely and replace any instance with a Recent Posts widget configured to replace it?

@wjhdev wjhdev self-assigned this Jun 1, 2015
@aschweigert
Copy link
Author

that would be fine, let's also make sure to nuke the associated prominence taxonomy terms in the process (assuming we nuke this and the footer featured one)

@wjhdev
Copy link

wjhdev commented Jun 1, 2015

I would remove the associate prominence terms by default, but keep them if there are already associated posts with them.

I'd do this out of concern for breaking some users workflow. If they're happy using the sidebar_featured and footer_featured terms to assign things to those spaces we can just drop a recent posts widget in there configured for that taxonomy and those terms.

They're happy because nothing changes. We're happy because we don't have to deal with that widget anymore.

@aschweigert
Copy link
Author

makes sense, should definitely not create it though for new installs

@wjhdev
Copy link

wjhdev commented Jun 25, 2015

Doing the simple part first and removing the widget from defaults in #762.

@aschweigert aschweigert assigned 0aveRyan and rnagle and unassigned wjhdev and 0aveRyan Jul 1, 2015
@benlk benlk assigned benlk and unassigned rnagle Jul 15, 2015
@benlk
Copy link
Collaborator

benlk commented Jul 16, 2015

Why in the world is the featured image thumbnail put after the h5 in the code? This makes little sense.

@rnagle rnagle modified the milestones: 0.5.2, 0.5.1 Jul 16, 2015
@aschweigert aschweigert modified the milestones: 0.5.3 - Widgets, 0.5.2 - Critical Bugfixes Only (Please) Jul 29, 2015
@benlk
Copy link
Collaborator

benlk commented Aug 17, 2015

If #800 is merged, this can be closed.

@benlk benlk closed this as completed Sep 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: normal Must be completed before release of this version of plugin. status: in progress type: bug
Projects
None yet
Development

No branches or pull requests

5 participants