Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated recommend widget from widget defaults. #762

Merged
merged 4 commits into from
Oct 26, 2015

Conversation

wjhdev
Copy link

@wjhdev wjhdev commented Jun 25, 2015

When the sidebar is empty, we (sometimes) include some default widgets. We should not be loading a deprecated widget in here.

@aschweigert
Copy link

If we do this we need to make sure the new widget is set to do the right thing (show the sidebar featured posts that would have appeared previously).

Even for new sites I'd question whether the recent posts widget should be included in the default stack of widgets...would we say that in 100% of cases sites would want to show X recent posts (with no filter applied) by default? I don't think so.

@rnagle rnagle self-assigned this Jul 13, 2015
@rnagle
Copy link

rnagle commented Jul 13, 2015

So, with this change, the line up for the sidebar fallback would be:

  • About this site
  • Follow widget
  • Support/donate widget (if donate link is specified in options)
  • Recent posts
  • Stories from INN members (if INN_MEMBER is true)

@aschweigert Could we just remove "Recent posts" and leave the others as they are? Or, should we scrap the entire fallback mechanism and just show "Go to the WP dashboard to add widgets to this sidebar" (or something along those lines)?

Apologies if I'm being daft, but I don't really understand why showing recent posts is a bad idea. Can you give an example where it would cause trouble?

@aschweigert
Copy link

I guess I just think this is maybe a bit heavy-handed as a default, probably makes more sense to just not load anything by default and show a notice pointing to the dashboard to add/configure widgets

@aschweigert
Copy link

has this been addressed already elsewhere?

@rnagle
Copy link

rnagle commented Oct 26, 2015

@aschweigert It doesn't look like this has been changed anywhere else.

I'll handle this, but before I do, I want to clarify -- we're talking about removing the existing fallback mechanism for the Main and Single sidebars, correct? That is, rather than show a default set of widgets, just say, "Hey, add some widgets to the '[Widget Area Name Here] Sidebar' via the WordPress dashboard."

@aschweigert
Copy link

I think for now leave the defaults, just remove the deprecated widget and account for that in the update script

…nt posts to replace the deprecated 'recommended' widget -- this matches what happens during the update/replacement of deprecated widgets
@rnagle
Copy link

rnagle commented Oct 26, 2015

@aschweigert OK -- so the recommended widget is already being dealt with as a part of the update/upgrade process. Since the update process swaps in a featured posts widget, I went back and modified this PR to follow suit. If there are no objections, I'm going to merge and close this, finally.

@aschweigert
Copy link

works for me

rnagle added a commit that referenced this pull request Oct 26, 2015
Remove deprecated recommend widget from widget defaults.
@rnagle rnagle merged commit 79c7c24 into develop Oct 26, 2015
@rnagle rnagle deleted the remove-depricated-widget-from-defaults branch November 3, 2015 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants