Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow floating social icons on two-column and other post templates #1102

Merged
merged 3 commits into from
Jan 27, 2016

Conversation

benlk
Copy link
Collaborator

@benlk benlk commented Jan 27, 2016

Changes

  • Removes the test of the post template when determining whether to output the floating social button template tag, javascript, and configuration JSON
  • Adds that test back into the configuration JSON function largo_floating_social_button_width_json, to increase the minimum width of viewport needed for the floating social buttons when using a template other than Largo's single-column template
  • Decreases the apparent spacing between the floating social buttons and the text column from 1 times the width of the floating social buttons to 0.7 times the width of the floating social buttons
  • Recompiles minified javascript for the above change

Why

For NPQ and VO-10, because we removed the sticky footer in 0.5.4.

@benlk benlk added this to the hotfix milestone Jan 27, 2016
@benlk
Copy link
Collaborator Author

benlk commented Jan 27, 2016

Questions:

  • are there any child themes that define their own templates with page column-widths differing from Largo's 1170px?
  • what child themes should this be tested against?

@aschweigert
Copy link

do we need any additional styling for this to make sure it gets positioned correctly? wasn't the reason we pulled it originally because it was appearing over the content in some cases?

@aschweigert
Copy link

as far as i know there are no child themes we host, using 0.5.4, that alter the overall page width from the 1170px default

@aschweigert
Copy link

i WOULD like to take a quick look at this on staging though, for all of the sites using the two column layout

@benlk
Copy link
Collaborator Author

benlk commented Jan 27, 2016

It was a worry.

I've checked this against posts in themes with different single templates:

  • current
  • npq
  • voiceofoc
  • gijn-impact

There haven't been any problems so far. The buttons are positioned outside the main page container div, so there haven't been conflicts.

aschweigert added a commit that referenced this pull request Jan 27, 2016
…are-buttons

Allow floating social icons on two-column and other post templates
@aschweigert aschweigert merged commit f66403a into master Jan 27, 2016
@aschweigert aschweigert deleted the VO-10-hotfix-two-column-floating-share-buttons branch January 27, 2016 21:48
benlk added a commit to INN/umbrella-largoproject that referenced this pull request Jan 18, 2017
benlk added a commit to INN/umbrella-largoproject that referenced this pull request Jan 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants