Use rawurlencode for maximum redundancy. #1121
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please don't use esc_attr for post titles that are part of URLs.
Changes
esc_attr
inlargo_post_social_buttons
withrawurlencode
: https://secure.php.net/manual/en/function.rawurlencode.phpWhy
Because the changes in https://github.com/INN/Largo/pull/1077/files were undone by the redo of the post social buttons.
To do:
Write tests for these buttons, perhaps as part of the
largo_post_social_links
redo in #219.