-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
404 page improvements #1168
404 page improvements #1168
Conversation
… URL, and add search to the search form if the search has been saerched.
This is separate from and complementary to #1167, which may be updated to work with this code at any point. |
Sorry, should have looked more closely at this. I'm not necessarily opposed to using wp_kses here (although I think it's overkill) but if we do it here...why aren't we using it for every text field in the theme options? For category/term descriptions? Everywhere else? It would make a lot more sense to have a globally allowed list of tags for user-entered description text. It's weird to make this the only exception and then it also makes the docs here way too heavy-handed. This should be re-thought. |
Created new ticket for that question: #1172 |
Changes
searchform.php
partials/content-not-found
displays the 404'd URL in a<code>
element before the search box if the page is a 404. Otherwise, it continues to display "Apologies, but no results were found. Perhaps searching will help.'"Here's an example with a successful search, showing the query in the search box:
An unsuccessful search, showing a different text suggesting running a different search:
A 404 page, showing the requested URL:
A 404 page on a child theme, showing custom text and HTML tags in use:
A hierarchical taxonomy term, showing the
content-not-found
partial used on 404 and empty search pages in the river, because the term has fewer than 5 posts.Why
For #692 and WE-103.
This is a hotfix because of the rapidity with which it is desired.