-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revisit the Taxonomy List widget #1171
Conversation
…de ability to exclude chosen terms, make the taxonomies option a select instead of a text field, improve docs inside and outside the plugin
We don't need the option for ascending/descending, reverse alphabetical order would never really make sense here. We also really do need the option to order by most recently updated (or maybe created?) term. And that's the only other option we need. So: alphabetical or most recent. That's it. Keep this simple. |
Simplified it to two options:
I think there's an argument for an oldest-term-first option, because sometimes the oldest terms will be the biggest buckets: things like a "News" or "Opinion" or "Very Important To Our Brand" term. |
A couple things:
|
To avoid merge conflicts, I'm going to add the docs to Jack's docs branch: https://github.com/INN/Largo/pull/1160/files#diff-09863b072aa8e2e4e3eb31c0735a1b92R178 The series rendering function has a lot of logic that isn't needed by the other terms, so that's why it should remain separate. But yes, the rest can be combined. |
…use generic render_term_list instead
Inline docs simplified, category and term rendering removed, and a new issue found: #1173 |
…(), improve its registration args when it's disabled. Remove unregister_post_types_taxonomy() and Largo_Term_Icons::register_taxonomy()
…t it needs to test.
Latest commits include a fix for #1173 and a more=thorough description of what needs to be done in the test for the function. |
@@ -443,29 +474,3 @@ function largo_first_headline_in_post_array($array) { | |||
|
|||
return $headline; | |||
} | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this section removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unregister_post_types_taxonomy
's check was moved into general taxonomy-registration function in inc/taxonomies.php
. It was moved there for consistency with other taxonomy-registration functions, but in any case it needed to be integrated with the function that registered the post-types
taxonomy, instead of registering a taxonomy without any labels.
I'm not sure why unregister_series_taxonomy
was removed; but the same registration fix should be applied to the series
taxonomy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR has been updated: The unregister_series_taxonomy
code has been placed into largo_custom_taxonomies
where the series taxonomy is registered.
or
|
probably not urgent enough to do this as a hotfix, can you resubmit against develop and we'll include it in the next release? |
Refiled as #1187. |
Changes
Add option to choose ascending or descending sort order, and docs: default is descendingAdd option to choose sort-by argument onget_terms
query: default is 'id'The combined defaults of descending by ID mean that the default is to show the most-recently-created terms in the taxonomy.
Why
To make the
For HELPDESK-589
What else?
This does not include the option to sort by last-updated; WordPress does not provide this option. 😞