Revisit the Taxonomy List widget

[benlk]

Changes

• Remove option to include only chosen terms
• Include ability to exclude chosen terms from returned terms
• Remove ability to output infinite terms, number output must be set and defaults to 5
• Make the taxonomies option a select instead of a text field, preventing empty-taxonomy error
• Add option to choose ascending or descending sort order, and docs: default is descending
• Add option to choose sort-by argument on get_terms query: default is 'id'
• Creates two sort options:
  • alphabetically by term name
  • newest term first, by descending order of term id
• Improve docs in the widget's settings

The combined defaults of descending by ID mean that the default is to show the most-recently-created terms in the taxonomy.

Why

To make the

For HELPDESK-589

What else?

This does not include the option to sort by last-updated; WordPress does not provide this option. 😞

[aschweigert]

We don't need the option for ascending/descending, reverse alphabetical order would never really make sense here. We also really do need the option to order by most recently updated (or maybe created?) term. And that's the only other option we need. So: alphabetical or most recent. That's it. Keep this simple.

[benlk]

Simplified it to two options:

• Sort by alphabetical order (name in ascending)
• Sort by most-recently-created (id in descending)

I think there's an argument for an oldest-term-first option, because sometimes the oldest terms will be the biggest buckets: things like a "News" or "Opinion" or "Very Important To Our Brand" term.

[aschweigert]

A couple things:

1. remove all these inline docs, put them in the regular widget docs and (possibly?) link to them
2. the various render term functions can be combined into one function, you can use the tax_query method of getting posts for all of these so I'm not sure why you need four separate, mostly duplicative functions

[benlk]

To avoid merge conflicts, I'm going to add the docs to Jack's docs branch: https://github.com/INN/Largo/pull/1160/files#diff-09863b072aa8e2e4e3eb31c0735a1b92R178

The series rendering function has a lot of logic that isn't needed by the other terms, so that's why it should remain separate. But yes, the rest can be combined.

[benlk]

Inline docs simplified, category and term rendering removed, and a new issue found: #1173

[benlk]

Latest commits include a fix for #1173 and a more=thorough description of what needs to be done in the test for the function.

[aschweigert]

why is this section removed?

[benlk]

unregister_post_types_taxonomy's check was moved into general taxonomy-registration function in inc/taxonomies.php. It was moved there for consistency with other taxonomy-registration functions, but in any case it needed to be integrated with the function that registered the post-types taxonomy, instead of registering a taxonomy without any labels.

I'm not sure why unregister_series_taxonomy was removed; but the same registration fix should be applied to the series taxonomy.

[benlk]

This PR has been updated: The unregister_series_taxonomy code has been placed into largo_custom_taxonomies where the series taxonomy is registered.

[benlk]

• Implement unregister_series_taxonomy in the same style as the change to the post-types taxonomy

or

• put unregister_series_taxonomy back

[aschweigert]

probably not urgent enough to do this as a hotfix, can you resubmit against develop and we'll include it in the next release?

[benlk]

Refiled as #1187.