Fix series landing page footer using wrong global $post after the sidebar is output #1176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschweigert
added a commit
that referenced
this pull request
Mar 21, 2016
…ostdata Fix series landing page footer using wrong global $post after the sidebar is output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Resets the global $post with
wp_reset_postdata()after the sidebar.Why
Widgets in the sidebar of the series landing page can mess with the global
$postvariable, causing the the series landing page footer to be drawn from a post that is not the series landing page. If the post mismatches, then contents of the footer are unreliable, and may not match the resired setting of non, sidebar, or custom HTML.This doesn't affect the landing page's LMP query, because the LMP query is encoded into the page before the sidebar is output, when the LMP partial is gotten.
This doesn't account for protections to widgets in the footer, because as far as I know Largo doesn't recommend or support putting post-dependent widgets in the global footer context. Plus, post-dependent widgets wouldn't be put there.
For HELPDESK-590.