-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Related Posts widget: make byline and thumbnail placement options work #1243
Conversation
Is the before/after option for the thumbnail a thing we actually want/need? Seems overly complicated for me unless there's a particularly good reason for it. |
I'm in favor of removing it. It is a needless complication, and it makes more sense for that to be a child-theme styles decision than a per-widget decision. |
go for it |
D we want an option to disable showing the thumbnail at all? |
…Related Posts widget, and clean up styles to make it easier for child themes to modify in the future
Before/After option and styles have been removed. |
the markup that uses that option is still in the widget though...right? |
Not sure what you mean by "the markup that uses that option" - the only difference to the markup on the thumbnail and the link inside it is that the thumbnail no longer has an |
I see, there was just a comment in there that made it look like that option was still present. Removed that and I think we're fine to merge this. |
Changes
show_byline
option now actually toggles the presence of the byline; defaults to notBefore/After headline option for thumbnail placement now has effectStyles for proper alignment of thumbnail in before and after positionsWhy
Because we had these options in the widget, but they weren't doing anything.
For #1242