-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1126 break up largo byline #1251
Conversation
…rtions of the largo byline function out into separate functions
…go_seo, for topical reasons
…wn components, for much the same reason as largo_byline was
…of errors. Somehow, the array() passed in largo_byline() to the largo_byline action is being outright replaced by a string, a string that is the output of largo_byline_coauthors() or so it appears. Here's the logged argument, and where it was throwing the error. [11-Jul-2016 18:25:05 UTC] '<span class="by-author"><span class="by">By</span> <span class="author vcard" itemprop="author"></span></span>' [11-Jul-2016 18:25:05 UTC] PHP Warning: extract() expects parameter 1 to be array, string given in /vagrant/wp-content/themes/largo-dev/inc/post-tags.php on line 165 [11-Jul-2016 18:25:05 UTC] '<span class="by-author"><span class="by">By</span> <span class="author vcard" itemprop="author"></span></span>' [11-Jul-2016 18:25:05 UTC] PHP Warning: extract() expects parameter 1 to be array, string given in /vagrant/wp-content/themes/largo-dev/inc/post-tags.php on line 165
…, thanks to Jake Spurlock
…his function does not exist
This reverts commit 8400768.
… it is" This reverts commit a30deda.
This reverts commit 004d339.
…t to largo_seo, for topical reasons" This reverts commit f5bb75b.
….php" This reverts commit 101bb1a.
…media.php" This reverts commit 792a9ad.
This reverts commit 10b3b4d.
… for Co-Authors Plus guest users
…go_get_user_avatar_id
This is ready for review; the failing tests appear to be the usual batch of PHP 5.5 type-safety and WordPress 4.4+ taxonomy term changes. |
* If job titles are enabled by Largo's theme option, display the one for this author | ||
*/ | ||
function job_title() { | ||
$show_job_titles = of_get_option( 'show_job_titles' ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
of_get_option should always have a default value set
@benlk just those couple small things, but otherwise this lgtm. nice work on this. huge improvement. |
Changes
Largo_Byline
to create a byline, in the new fileinc/byline_class.php
32x32
image'edit_published_posts'
capability, where before it was merely'edit_posts'
capability. The distinction is that if a user cannot edit a published post, now they will not see the link.largo_byline()
to a wrapper around$byline = new Largo_Byline( $options );
Largo_Byline
to support coauthors withLargo_CoAuthors_Byline
Largo_Byline
to support Largo custom bylines withLargo_Custom_Byline
Largo_Custom_Byline
is fully separate fromLargo_Byline
to make deprecating it easier when we implement Deprecate Largo's custom byline feature #1249.Largo_Custom_Byline
andLargo_CoAuthors_Byline
output tolargo_byline()
when situationally appropriate.largo_byline()
will awaysreturn
the byline's HTML now, where before it only returned if it wasn'techo
ing the bylineline-height
.largo_get_avatar_src
that was trying to use email addresses as user IDsWhy
Continuing on #1248 for #1126, this is the cleanup of that PR with requested changes. This replaces the action created in that PR with a series of classes, each only applied at the correct time.
Questions for review
@since
tag?