-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
consolidate content-series and default content partials #1280
Conversation
todo:
|
Also, check that this still works with LMP in series. |
Note to self:
|
As far as removing the youtube_url-specific things, we can lose them in favor of largo_get_featured_media, which I believe will work with youtube_url-containing posts. That will result in videos and embeds and galleries rendering as such, instead of using the thumbnail. We could only display the thumbnail. @aschweigert is that an acceptable solution? |
Thumbnails it is. |
Getting the filter to work is making progress slow. |
…e for development purposes.
This will need to be updated with https://github.com/INN/Largo/pull/1291/files#diff-33b54c9d0b2a8a7010bb416509a2e69fR14 |
some docs on |
…variable that gets extracted
…ether an image is featured in a series to the existence of the featured prominence term.
|
New things in the PR:
Regarding the @aschweigert, this is ready for review. |
still a work in progress, fix for #1271, this replaces #1277