Social Sharing: Move mailto functionality from js to html #1281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -88,7 +88,13 @@ function largo_post_social_links( $echo = true ) { | |||
| } | |||
|
|
|||
| if ( $utilities['email'] === '1' ) { | |||
| $output .= '<span data-service="email" class="email custom-share-button share-button"><a><i class="icon-mail"></i> <span class="hidden-phone">' . esc_attr( __( 'Email', 'largo' ) ) . '</span></a></span>'; | |||
| $output .= sprintf( | |||
| '<span data-service="email" class="email share-button"><a href="mailto:?subject=%2$s&body=%3$s%0D%0A%4$s" target="_blank"><i class="icon-mail-alt"></i> <span class="hidden-phone">%1$s</span></a></span>', | |||
There was a problem hiding this comment.
Just a quick note on this -
The body field still opens in Apple Mail with the post URL appended to the end of the excerpt (no space in-between), but I don't believe there's any way around this.
We could add a <br /> tag, but that's not the correct way to do that, and it would likely have mixed results in browser-driven email applications.
For more info, see http://stackoverflow.com/questions/22765834/insert-a-line-break-in-mailto-body#22765878
| $output .= '<span data-service="email" class="email custom-share-button share-button"><a><i class="icon-mail"></i> <span class="hidden-phone">' . esc_attr( __( 'Email', 'largo' ) ) . '</span></a></span>'; | ||
| $output .= sprintf( | ||
| '<span data-service="email" class="email share-button"><a href="mailto:?subject=%2$s&body=%3$s%0D%0A%4$s" target="_blank"><i class="icon-mail-alt"></i> <span class="hidden-phone">%1$s</span></a></span>', | ||
| esc_attr( __( 'Email', 'npr' ) ), |
There was a problem hiding this comment.
can't edit your fork but need to use the largo textdomain here instead of npr
|
other than that one textdomain issue this lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per #799, this PR removes the js code that builds the mailto link, and adds it to the template files instead.