Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing duplicate code for navigation toggle on mobile #1286

Merged
merged 1 commit into from
Sep 7, 2016

Conversation

rclations
Copy link

fixes #1166

The code removed here was duplicating the work in L166-215, causing issues on iOS mobile.

To reproduce, use Chrome developer tools device emulation for iPhone and test secondary navigation opens on the main navigation menu.

Previously, on click, the js would both add and remove the open class, appearing to do nothing for the end user. This removed the additional code so the open class is added and removed where appropriate.

@benlk
Copy link
Collaborator

benlk commented Sep 7, 2016

Tested in the iOS simulator; it works there.

We don't have any notes in the original issue remarking on whether or not this affected the iOS simulator; it did not affect Chrome on Android at the time that I commented on that issue.

Do we want to try this in production, so it can be tested against actual iDevices instead of emulated ones?

@rclations
Copy link
Author

good idea - I just loaded this up on our umbrella staging, and it seems to be working

@rclations rclations merged commit 86ae067 into WPBuddy:develop Sep 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants