Temporarily empty out $wp_query->posts in the homepage bottom widget area

[benlk]

Changes

• in the Homepage Bottom Widget Area homepage bottom partial, temporarily empty $wp_query->posts
• add comments explaining why we do this
• reference a commit and pull request that explains that a little more, because otherwise we'll be scratching our heads when we debug this the next time.

Why

Because the first recent posts widget in homepage bottom widget area skips 10 posts when "do not duplicate" is enabled.

From Asana:

Ben: In largo-dev/inc/widgets/largo-recent-posts.php, line 63-69, if the checkbox to ignore shown posts is checked, the widget not only ignores $shown_ids but adds the posts from the main query on the page to the list of ids to be ignored in the query. It doesn't add those posts to $shown_ids, but just joins them to the array of post ids to be ignored.

Adam: i would want to look first at why we did that in the first place. It seems like probably not a thing we'd want to do...unless it is? for some unknown reason.

Ben: Largo commit 4443b30 has the reason: Adding the main river of posts to $shown_ids messes up the LMP button that gets rendered at the end of the river. So grabbing the posts from $wp_query->posts fixes that.
Homepage bottom widget area, partials/home-bottom-widget-area.php, would be the place to nix the global $wp_query->posts array and then put it back, if we wanted to do that.

Adam: yeah i guess that's what we'd need to do (until we blow up LMP or figure out a better way to handle that)

This PR doesn't have a corresponding issue because of the Dyn DNS DDOS of 2016-10-21. 😞

[rclations]

@benlk looks good, just want to confirm this should be applied against master

[benlk]

Yep, this should be in master, because this is a hotfix for production.

The failing Travis is due to

Either https://www.facebook.com/abcdefghijklmnopqrstuvwxyz12 is user that exists and allows follows, or the Facebook follow button iframe HTML structure has changed and largo_fb_url_to_username no longer operates predictably.

[aschweigert]

need to merge master -> develop to make sure we catch this there as well, @benlk can you take care of that?

[benlk]

Sure