Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Travis CI config, fix broken tests, update README, and diverse minor fixes #1503

Merged
merged 15 commits into from
Jul 26, 2018

Commits on Jul 25, 2018

  1. Configuration menu
    Copy the full SHA
    b9aedaf View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    97eb940 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    85ba11c View commit details
    Browse the repository at this point in the history
  4. Update team list in readme.md

    benlk committed Jul 25, 2018
    Configuration menu
    Copy the full SHA
    abf6948 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    fb049d8 View commit details
    Browse the repository at this point in the history
  6. Deprecate largo_fb_user_is_followable

    largo_fb_user_is_followable used the Facebook Follow Button,
    https://developers.facebook.com/docs/archive/docs/plugins/follow-button/
    in order to determine whether a user or page was followable. By using
    this public button's HTML markup, we were able to make the followability check
    without using the Facebook Graph API.
    
    Facebook deprecated that button on February 5, 2018.
    
    To query the Graph API, we need to have an API key.
    
    To require Largo users to acquire an API key, for the sole purpose of checking
    whether their Facebook page is followable, seems excessive.
    
    Therefore, since there's no reasonable way to check whether a Facebook
    profile is followable, deprecate the functionality by making the
    function always return false, and clean out its tests. If WP_DEBUG or LARGO_DEBUG
    are set, provide a deprecation notice to the error log.
    benlk committed Jul 25, 2018
    Configuration menu
    Copy the full SHA
    7c68ff6 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    8ede249 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    d873150 View commit details
    Browse the repository at this point in the history
  9. largo_remove_hero(): remove regex portion that matches an src in the …

    …img tag, as it's not necessary for this function and appears to be the cause of #1404
    benlk committed Jul 25, 2018
    Configuration menu
    Copy the full SHA
    75aad91 View commit details
    Browse the repository at this point in the history
  10. Afer removing image, remove empty p tag

    For #1503 (comment)
    
    This change:
    
    - removes an empty <p></p>
    - removes an empty <p class="whatever"></p>
    - removes the image but not the p if it's a <p><img/>foo</p>
    - checks that the foo is left behind
    - checks that a non-matching image isn't removed
    benlk committed Jul 25, 2018
    Configuration menu
    Copy the full SHA
    35e9492 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    8c4ad0f View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    79ab088 View commit details
    Browse the repository at this point in the history
  13. largo_remove_hero: Add two more test cases: global post is not set, c…

    …urrent post does not have featured media thumbnail
    benlk committed Jul 25, 2018
    Configuration menu
    Copy the full SHA
    a2a20aa View commit details
    Browse the repository at this point in the history
  14. undefined variable, doh

    benlk committed Jul 25, 2018
    Configuration menu
    Copy the full SHA
    b8f7782 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2018

  1. Configuration menu
    Copy the full SHA
    ff1e345 View commit details
    Browse the repository at this point in the history