forked from argoproject/Argo
-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Travis CI config, fix broken tests, update README, and diverse minor fixes #1503
Merged
Commits on Jul 25, 2018
-
Configuration menu - View commit details
-
Copy full SHA for b9aedaf - Browse repository at this point
Copy the full SHA b9aedafView commit details -
Configuration menu - View commit details
-
Copy full SHA for 97eb940 - Browse repository at this point
Copy the full SHA 97eb940View commit details -
Configuration menu - View commit details
-
Copy full SHA for 85ba11c - Browse repository at this point
Copy the full SHA 85ba11cView commit details -
Configuration menu - View commit details
-
Copy full SHA for abf6948 - Browse repository at this point
Copy the full SHA abf6948View commit details -
Configuration menu - View commit details
-
Copy full SHA for fb049d8 - Browse repository at this point
Copy the full SHA fb049d8View commit details -
Deprecate largo_fb_user_is_followable
largo_fb_user_is_followable used the Facebook Follow Button, https://developers.facebook.com/docs/archive/docs/plugins/follow-button/ in order to determine whether a user or page was followable. By using this public button's HTML markup, we were able to make the followability check without using the Facebook Graph API. Facebook deprecated that button on February 5, 2018. To query the Graph API, we need to have an API key. To require Largo users to acquire an API key, for the sole purpose of checking whether their Facebook page is followable, seems excessive. Therefore, since there's no reasonable way to check whether a Facebook profile is followable, deprecate the functionality by making the function always return false, and clean out its tests. If WP_DEBUG or LARGO_DEBUG are set, provide a deprecation notice to the error log.
Configuration menu - View commit details
-
Copy full SHA for 7c68ff6 - Browse repository at this point
Copy the full SHA 7c68ff6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ede249 - Browse repository at this point
Copy the full SHA 8ede249View commit details -
Configuration menu - View commit details
-
Copy full SHA for d873150 - Browse repository at this point
Copy the full SHA d873150View commit details -
largo_remove_hero(): remove regex portion that matches an src in the …
…img tag, as it's not necessary for this function and appears to be the cause of #1404
Configuration menu - View commit details
-
Copy full SHA for 75aad91 - Browse repository at this point
Copy the full SHA 75aad91View commit details -
Afer removing image, remove empty p tag
For #1503 (comment) This change: - removes an empty <p></p> - removes an empty <p class="whatever"></p> - removes the image but not the p if it's a <p><img/>foo</p> - checks that the foo is left behind - checks that a non-matching image isn't removed
Configuration menu - View commit details
-
Copy full SHA for 35e9492 - Browse repository at this point
Copy the full SHA 35e9492View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8c4ad0f - Browse repository at this point
Copy the full SHA 8c4ad0fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 79ab088 - Browse repository at this point
Copy the full SHA 79ab088View commit details -
largo_remove_hero: Add two more test cases: global post is not set, c…
…urrent post does not have featured media thumbnail
Configuration menu - View commit details
-
Copy full SHA for a2a20aa - Browse repository at this point
Copy the full SHA a2a20aaView commit details -
Configuration menu - View commit details
-
Copy full SHA for b8f7782 - Browse repository at this point
Copy the full SHA b8f7782View commit details
Commits on Jul 26, 2018
-
Configuration menu - View commit details
-
Copy full SHA for ff1e345 - Browse repository at this point
Copy the full SHA ff1e345View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.