Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conditionally enqueue slideshow assets for gallery #1568

Closed
wants to merge 3 commits into from
Closed

Conditionally enqueue slideshow assets for gallery #1568

wants to merge 3 commits into from

Conversation

benlk
Copy link
Collaborator

@benlk benlk commented Nov 10, 2018 •
edited
Loading

🚨 currently broken:

  • galleries on posts

⚠️ unknown:

  • featured media galleries
  • any other places where the gallery styles/js are needed (Gallery widget?)

Changes

  • stops running largo_gallery_enqueue() on every page
  • for all the assets in largo_gallery_enqueue(), enqueue them in the footer

Why

Fixes #1113 by only enqueueing the JS/CSS when it's needed.

@benlk benlk added this to the 0.6.1 - Bugfixes milestone Nov 10, 2018
@benlk benlk added type: improvement priority: normal Must be completed before release of this version of plugin. status: in progress status: needs review category: styles affects lots of styles, requiring visual testing labels Nov 10, 2018
benlk added a commit that referenced this pull request Nov 10, 2018
@benlk
Error-free author bio output when a post has no author metadata.
7e7b4cd 
Cherry-picks some stuff from #1568
Part of the #1492 whack-a-mole
@benlk benlk modified the milestones: 0.6.1 - Bugfixes, 0.6.2 Dec 6, 2018
@benlk benlk modified the milestones: 0.6.2, 0.6.3 Dec 19, 2018
@benlk
Copy link
Collaborator Author

benlk commented Apr 24, 2019

Note that "Gallery" functionally means any image block or image.

@benlk benlk removed this from the 0.6.4 milestone Apr 26, 2019
@benlk benlk closed this Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
category: styles affects lots of styles, requiring visual testing priority: normal Must be completed before release of this version of plugin. status: in progress status: needs review type: improvement
Projects
None yet
Milestone
0.7 - Foundation for Customization
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@benlk