Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1540 update grunt dependencies #1899

Merged
merged 5 commits into from
Apr 16, 2021
Merged

#1540 update grunt dependencies #1899

merged 5 commits into from
Apr 16, 2021

Conversation

rlambertsen
Copy link
Collaborator

Changes

This pull request makes the following changes:

  • Update Grunt dependencies to latest versions
  • add package.json lock file to keep npm packages locked to our versions we push
  • Update change-log with changes
  • build process for grunt was changed to allow developers to run separate commands

Why

For #1540

Testing/Questions

Features that this PR affects:

  • Development work flow

Questions that need to be answered before merging:

  • Is this PR targeting the correct branch in this repository?
  • Has the changelog.md file been updated to reflect the updates in this PR?

Steps to test this PR:

  1. Just pull down, merge changes, package.json should have latest versions (see this branches package.json)

Additional information

WP Buddy Client requesting: (if applicable)

  • Contributor has read WP Buddy's GitHub code of conduct
  • Contributor would like to be mentioned in the release notes as: admin
  • Contributor agrees to the license terms of this repository.

benlk
benlk reviewed Mar 30, 2021
View reviewed changes
Gruntfile.js Outdated Show resolved Hide resolved
@joshdarby joshdarby linked an issue Apr 16, 2021 that may be closed by this pull request
Update Grunt dependencies #1540
Closed
@joshdarby joshdarby added category: clean up unused code/clean up items Estimate: < 2 Hours priority: normal Must be completed before release of this version of plugin. status: needs review type: improvement labels Apr 16, 2021
@rlambertsen
Merge branch 'trunk' of https://github.com/WPBuddy/largo into #1540_U…
ccad503 
…pdate_Grunt_dependencies

� Conflicts:
�	changelog.md
@rlambertsen rlambertsen merged commit fbb287e into trunk Apr 16, 2021
@rlambertsen rlambertsen mentioned this pull request Apr 16, 2021
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benlk benlk benlk left review comments

@joshdarby joshdarby joshdarby approved these changes

@billmca20 billmca20 Awaiting requested review from billmca20

Assignees

@rlambertsen rlambertsen

Labels
category: clean up unused code/clean up items Estimate: < 2 Hours priority: normal Must be completed before release of this version of plugin. status: needs review type: improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Grunt dependencies
3 participants
@rlambertsen @benlk @joshdarby