Series byline fix #639
Merged
Series byline fix #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Landing pages were loading partials/content when partials/content-series is used on landing pages. - [ ] added an indicator sent with LMP data to alert the dom generating function that this is a series landing page - [ ] pass $opt variable that partials/content-series uses to determine the dom to return. - [ ] be a good person and restore global $post after the landing page is done using it. We can probably (in the future) overhaul the series page template to simplify how it asks and controls dom.
Fix for #452 - [x] restore wp_query after partials/content-series is finished. - [x] added is_series_landing() conditional to abstract checking the post type. - [x] tell the widget that is_series_landing() posts are ok too.
3 tasks
This was referenced Apr 6, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #452
This pull request also contains commits from #638, because they touch the same piece of code. That pull request can be closed once this is merged in.