#399 custom tax in menus #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the series/post types are not enabled, don’t show them as a menu item. See my comment on: http://stackoverflow.com/a/8363082/620680
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did some testing and I couldn't get a largo setup that replicated #399. However, I found another bug that I believe may be the source.
If series are disabled and a user is created, the first time they visit the menu page they will get an option set to hide
add-seriesandadd-post-typeon the menu page (because these taxonomies are still registered as 'ghost' taxonomies). If the series are then enabled, they'll be hidden.The simple fix: If the series/post types are not enabled, be explicit and not allow them as a menu item.
See my comment on:
http://stackoverflow.com/a/8363082/620680
We should still keep an eye on this.