Deprecate $use_more and $more_link args for largo_excerpt #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
My only concern is that this doesn't have tests. https://github.com/INN/Largo/tree/668-65-largo_excerpt has WIP tests, but they're failing right now on the homepage. |
rnagle
changed the title
…ts, refactor largo_excerpt a bit along the way
|
OK -- I updated the branch, borrowing your tests from |
|
Looks good to me. |
rnagle
added a commit
that referenced
this pull request
Jun 29, 2015
Deprecate $use_more and $more_link args for largo_excerpt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This effectively removes the "more..." or "continue reading" links from the ends of excerpts. Fixes #52.