Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post social icon styles updates #951

Merged
merged 13 commits into from
Nov 3, 2015
Merged

Conversation

benlk
Copy link
Collaborator

@benlk benlk commented Oct 28, 2015

Changes

  • Removes .left and .right grouping of social icons
  • Removes the padding around general .widget and puts it on #sidebar .widget.
  • Replaces .icon-email class on containing span.email with an i.icon-email inside the span, for consistency
  • Removes the responsive style that hid the print button on mobile.
  • Adds .hidden-phone to the text labels.
  • Adds .largo-follow to the post social icons at the top of the article page, so that that grabs styles from the Largo Follow widget for coloration of buttons. (This could be done the other way around as well: copy the Largo Follow styles into the post social section of single.less and then add their class to the Largo Follow widget.)
  • Does not affect the Largo sticky footer.

Width of 420 px, approximately phone-like:

screen shot 2015-10-28 at 4 27 39 pm

Width of 769 px, the smallest at which the labels will show.

screen shot 2015-10-28 at 5 36 29 pm

The padding on the left of these icons is because of the problem described in #950.

Why

For WE-18, and Women's eNews and RNS.

For #950, which had the problem where widgets in the article-bottom position were not as wide as the column:

screen shot 2015-10-28 at 3 30 47 pm

## Questions - [ ] should I move the coloration styles out of `.largo-follow`? - [x] should this fix #950?

@aschweigert
Copy link

What's with the weird left margin when it's at the bottom of the post?

@benlk
Copy link
Collaborator Author

benlk commented Oct 28, 2015

#950 is what's up. Should I tackle that here?

@aschweigert
Copy link

yes.

@benlk
Copy link
Collaborator Author

benlk commented Oct 28, 2015

Updated with a fix for #950 and new screenshots.

@aschweigert aschweigert modified the milestone: 0.5.3 - Widgets Oct 30, 2015
@benlk
Copy link
Collaborator Author

benlk commented Nov 3, 2015

Moving coloration styles out of .largo-follow isn't essential.

Looks good in the Android 4.2.2 browser:

screenshot_2015-11-03-12-18-40

screenshot_2015-11-03-12-19-00

@benlk
Copy link
Collaborator Author

benlk commented Nov 3, 2015

Now with proper :hover colors.

…r the content of the buttons, make sure the email hover state uses the pointer cursor
@rnagle
Copy link

rnagle commented Nov 3, 2015

Going to merge this to develop.

We'll still need a thorough check of member themes before we're able to deploy this.

rnagle added a commit that referenced this pull request Nov 3, 2015
@rnagle rnagle merged commit e037f48 into develop Nov 3, 2015
@aschweigert
Copy link

@benlk the email button is not working for me, is that a known issue?

@benlk
Copy link
Collaborator Author

benlk commented Nov 24, 2015

Unless it's #799, it's not a known issue.

@benlk benlk deleted the WE-18-post-social-icon-colors branch February 3, 2016 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants