Asub 8384/subs profile #2107

edwardcho1231 · 2024-04-26T20:24:52Z

Be sure to run npm test, npm run lint, and write detailed test steps before requesting reviewers

Description

Jira Ticket: ASUB-8384

Information about what you changed for this PR. Include any dependencies, companion PRs, relevant screenshots, or config changes.

Test Steps

Add detailed test steps a reviewer must complete to test this PR

Checkout this branch git checkout {branch name}
Run fusion repo with linked blocks npx fusion start -f -l {blocks to link}
{Next ....}

Bumps [@babel/preset-react](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-react) from 7.23.3 to 7.24.1. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.24.1/packages/babel-preset-react) --- updated-dependencies: - dependency-name: "@babel/preset-react" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Added esc event listener to useEffect --------- Co-authored-by: Malavika Koppula <mkreddy1110@gmail.com>

* Added flex to section-title links --------- Co-authored-by: Malavika Koppula <mkreddy1110@gmail.com>

Bumps [algoliasearch](https://github.com/algolia/algoliasearch-client-javascript) from 4.23.1 to 4.23.2. - [Release notes](https://github.com/algolia/algoliasearch-client-javascript/releases) - [Changelog](https://github.com/algolia/algoliasearch-client-javascript/blob/master/CHANGELOG.md) - [Commits](algolia/algoliasearch-client-javascript@4.23.1...4.23.2) --- updated-dependencies: - dependency-name: algoliasearch dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [eslint-plugin-react](https://github.com/jsx-eslint/eslint-plugin-react) from 7.33.2 to 7.34.1. - [Release notes](https://github.com/jsx-eslint/eslint-plugin-react/releases) - [Changelog](https://github.com/jsx-eslint/eslint-plugin-react/blob/v7.34.1/CHANGELOG.md) - [Commits](jsx-eslint/eslint-plugin-react@v7.33.2...v7.34.1) --- updated-dependencies: - dependency-name: eslint-plugin-react dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [glob](https://github.com/isaacs/node-glob) from 10.3.10 to 10.3.12. - [Changelog](https://github.com/isaacs/node-glob/blob/main/changelog.md) - [Commits](isaacs/node-glob@v10.3.10...v10.3.12) --- updated-dependencies: - dependency-name: glob dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* add focal point code and tests * fix eslint errors * fix formatting * fix formatting p2

* Sign In with Apple * fixing linting and tests * fixing test & linting * fixing linting errors * removing update from package.json * fixing linting errors * disable eslint warnings * fixing warnings * fixing sintax * removing keys * removing only * fixing linting errors

* added dd-service-catalog.yml * updated infrastructure

* sign up with reCaptcha * fixing linting and tests * fixing linting errors * fixing linting errors

* lokalize-translation 2.3.0 * attending feedback

* THEMES-1066: updated versions of storybook and chromatic to the latest. * THEMES-1066: fixed linting errors * THEMES-1066 adjusted configs so that storybook could build without errors. * THEMES-1066 remove addon-knobs * THEMES-1066: removing more deprecated packages. * THEMES-1066: added .babelrc * THEMES-1066: moved babel config to main.js * version bump * added alias overrides * Fixed intro page * THEMES-1066: fixed webpack/babel config * THEMES-1066: restore babel.config.js * THEMES-1066: restore babel.config.js * THEMES-1066: added styling storybook addon * THEMES-1066: updated preview to just use news.scss * THEMES-1066: fixed breaking stories and updated news.scss. * THEMES-1066: version bump for storybook * THEMES-1066: corrected whitespace * THEMES-1066: Updating option for chromatic action. * THEMES-1066: updated stylelint to hopefully fix the UI Tests check * THEMES-1066: removed jsx from stylelint action input. * THEMES-1066: added env vars to chromatic action * THEMES-1066: removing test vars from workflow file.

…ofile

blocks/subscriptions-block/_index.scss

blocks/subscriptions-block/features/SubscriptionProfileManagement/default.jsx

...ions-block/features/SubscriptionProfileManagement/children/BasicSubscriptionDetail/index.jsx

LauraPinilla

Hi @edwardcho1231
It looks good to me, just some minor styles that we can try to fix,
For example:

the modal
Gap between payment method and next bill

LauraPinilla

@edwardcho1231 before merge, do you mind check with Pardis, where we should provide the error message, in case cancelation/recue fails.

LauraPinilla

Thanks for your hard work on this @edwardcho1231 , LGTM!

LauraPinilla

Hi @edwardcho1231 by checking something for a demo I noticed something.
The info provided for inactive subscriptions should be a little bit different. However I'm seeing this. Do you mind check this

Payment method & billing address shouldn't appear. Instead of that, we need to show "Subscription period"

LauraPinilla

Thanks @edwardcho1231 for all these changes, LGTM!

vgalatro

@edwardcho1231 , left some questions and suggested cleanup on the PR. Also there's quite a few logical property conversions that are needed.

blocks/subscriptions-block/components/utils.js

...ions-block/features/SubscriptionProfileManagement/children/BasicSubscriptionDetail/index.jsx

blocks/subscriptions-block/components/utils.js

blocks/subscriptions-block/themes/news.json

blocks/subscriptions-block/components/utils.js

vgalatro

Changes all look good, approved!

dependabot bot and others added 15 commits March 27, 2024 12:19

Added esc event listener to useEffect (#2044)

4da53be

* Added esc event listener to useEffect --------- Co-authored-by: Malavika Koppula <mkreddy1110@gmail.com>

Added overflow to section-title links (#2027)

6cee0cd

* Added flex to section-title links --------- Co-authored-by: Malavika Koppula <mkreddy1110@gmail.com>

Manual promo blocks now respect focal point (#1996)

34b1c78

* add focal point code and tests * fix eslint errors * fix formatting * fix formatting p2

shorten PR template based on eng sync discussions (#2065)

3eb16fc

added dd-service-catalog.yml (#2089)

8495391

* added dd-service-catalog.yml * updated infrastructure

ASUB-8195 Sign up with reCaptcha (#2068)

41c9009

* sign up with reCaptcha * fixing linting and tests * fixing linting errors * fixing linting errors

Lokalize-translation 2.3.0 (#2092)

c9dceb9

* lokalize-translation 2.3.0 * attending feedback

Merge branch 'arc-themes-release-version-2.3.1' into ASUB-8384/subsPr…

6cb133e

…ofile

add subscription profile management feature and cancel/resub flows

89e01cb

edwardcho1231 requested a review from a team as a code owner April 26, 2024 20:24

github-actions bot reviewed Apr 26, 2024

View reviewed changes

edwardcho1231 added 4 commits April 26, 2024 16:46

address lint errors

72a66fa

fix some lint issues

bda27ee

update some tests

d273f59

auto fix styles lint

417305c

edwardcho1231 requested a review from LauraPinilla April 28, 2024 03:01

LauraPinilla reviewed Apr 30, 2024

View reviewed changes

blocks/subscriptions-block/features/SubscriptionProfileManagement/default.jsx Outdated Show resolved Hide resolved

LauraPinilla reviewed Apr 30, 2024

View reviewed changes

...ions-block/features/SubscriptionProfileManagement/children/BasicSubscriptionDetail/index.jsx Outdated Show resolved Hide resolved

LauraPinilla previously approved these changes Apr 30, 2024

View reviewed changes

LauraPinilla reviewed Apr 30, 2024

View reviewed changes

fix some styles

baef5e8

edwardcho1231 dismissed LauraPinilla’s stale review via baef5e8 April 30, 2024 18:58

edwardcho1231 added 2 commits May 1, 2024 14:39

fix lint errors

a73aa5e

update tests

5998c7f

edwardcho1231 requested a review from LauraPinilla May 2, 2024 02:18

edwardcho1231 added 3 commits May 1, 2024 22:48

add more test

2b8598a

use icons from components repo

186b145

add tests

a26ad00

edwardcho1231 added the ready for review The PR author has completed the PR template and is ready for a review label May 2, 2024

LauraPinilla approved these changes May 3, 2024

View reviewed changes

LauraPinilla requested changes May 3, 2024

View reviewed changes

fix inactive sub card

84fd73d

edwardcho1231 requested a review from LauraPinilla May 6, 2024 16:33

LauraPinilla previously approved these changes May 6, 2024

View reviewed changes

vgalatro added review in progress A review is underway. Even if an approval has been submitted, wait for all reviews to be completed. and removed ready for review The PR author has completed the PR template and is ready for a review labels May 7, 2024

vgalatro suggested changes May 7, 2024

View reviewed changes

vgalatro added needs changes The reviewer has requested changes from the PR author and removed review in progress A review is underway. Even if an approval has been submitted, wait for all reviews to be completed. labels May 7, 2024

address feedback

9867920

edwardcho1231 dismissed LauraPinilla’s stale review via 9867920 May 7, 2024 18:08

edwardcho1231 requested a review from vgalatro May 7, 2024 18:09

edwardcho1231 added ready for review The PR author has completed the PR template and is ready for a review and removed needs changes The reviewer has requested changes from the PR author labels May 7, 2024

vgalatro reviewed May 7, 2024

View reviewed changes

blocks/subscriptions-block/components/utils.js Outdated Show resolved Hide resolved

remove eslint disable next line

7b72f1f

vgalatro approved these changes May 7, 2024

View reviewed changes

vgalatro added ready to merge It's time! Merge this PR. Woo! and removed ready for review The PR author has completed the PR template and is ready for a review labels May 7, 2024

edwardcho1231 merged commit 27458c9 into arc-themes-release-version-2.3.1 May 7, 2024
8 checks passed

edwardcho1231 deleted the ASUB-8384/subsProfile branch May 7, 2024 19:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Asub 8384/subs profile #2107

Asub 8384/subs profile #2107

edwardcho1231 commented Apr 26, 2024 •

edited by jira bot

Loading

LauraPinilla left a comment

LauraPinilla left a comment

LauraPinilla left a comment

LauraPinilla left a comment •

edited

Loading

LauraPinilla left a comment

vgalatro left a comment

vgalatro left a comment

Asub 8384/subs profile #2107

Asub 8384/subs profile #2107

Conversation

edwardcho1231 commented Apr 26, 2024 • edited by jira bot Loading

Description

Jira Ticket: ASUB-8384

Test Steps

LauraPinilla left a comment

Choose a reason for hiding this comment

LauraPinilla left a comment

Choose a reason for hiding this comment

LauraPinilla left a comment

Choose a reason for hiding this comment

LauraPinilla left a comment • edited Loading

Choose a reason for hiding this comment

LauraPinilla left a comment

Choose a reason for hiding this comment

vgalatro left a comment

Choose a reason for hiding this comment

vgalatro left a comment

Choose a reason for hiding this comment

edwardcho1231 commented Apr 26, 2024 •

edited by jira bot

Loading

LauraPinilla left a comment •

edited

Loading