Create react-native-ci.yml #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| on: | ||
| push: | ||
| branches: | ||
| - MaryJabro # Temporary for testing: Adjust to main before pushing to main |
There was a problem hiding this comment.
oops looks like you missed this. need to change this to main
There was a problem hiding this comment.
oops looks like you missed this. need to change this to main
updating it to main right now, had it as MaryJabro for testing
| - MaryJabro # Temporary for testing: Adjust to main before pushing to main | ||
| pull_request: | ||
| branches: | ||
| - MaryJabro #Temporary for testing: Adjust to main before pushing to main |
|
Another thing is when this eventually gets approved lets make sure we squash and merge since you have 11 commits. The reason we want to do this is because we don't want to pollute the main branch with a bunch of commits that don't make much sense. Also if something goes wrong we can pinpoint the commit that caused it easier. |
|
Looks good to me now. Approved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added GitHub Actions workflow for Android APK build and testing. Needs reviewal to ensure correctness