Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UserLoans#create | POST "api/v1/users/:id/loans" #45

Merged
merged 5 commits into from
Oct 21, 2023

Conversation

kem247
Copy link
Contributor

@kem247 kem247 commented Oct 21, 2023

Changes:

  • added a routes path, controller method , and testing to create a new loan between an owner, their puzzle and a borrower

This is related to #34

This closes #34

[x] I linted my work. (RuboCop)

[] I've updated documentation & README. (if necessary)


(For Fun!) Please include a link to a meme/gif of your feelings about this branch!

Link:

Copy link
Contributor

@MelTravelz MelTravelz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see RuboCop changed some of our Condrollers from something like:
Api::V1::Users::PuzzlesController < ApplicationController

into:
module Api
module V1
module Users
class PuzzlesController < ApplicationController

It's ok and doesn't hurt anything, but please don't just accept all changed from RuboCop...sometimes it gives bad advice

@MelTravelz MelTravelz merged commit 735c1c6 into main Oct 21, 2023
1 check passed
@MelTravelz MelTravelz assigned MelTravelz and kem247 and unassigned MelTravelz Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UserLoans#create | POST "api/v1/users/:id/loans"
2 participants