UserLoans#update | PATCH api/v1/users/:id/loans/:id
#51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MelTravelz
reviewed
Oct 22, 2023
| def update | ||
| user = User.find(params[:id]) | ||
| loans = Loan.where(owner_id: user.id).or(Loan.where(borrower_id: user.id)) | ||
| loan_id = loans.find(params[:loan_id]) |
There was a problem hiding this comment.
This variable name should change from loan_id to loan since it is a loan object and not just an id number
MelTravelz
reviewed
Oct 22, 2023
|
|
||
| def update | ||
| user = User.find(params[:id]) | ||
| loans = Loan.where(owner_id: user.id).or(Loan.where(borrower_id: user.id)) |
There was a problem hiding this comment.
this logic is not needed since we have the loan_id being passed through params:
loan = Loan.find(params[:id])
MelTravelz
reviewed
Oct 22, 2023
|
|
||
| if params[:action_type] == 'deny' || params[:action_type] == 'withdraw' | ||
| if loan_id.update(status: 2) | ||
| dashboard_info = user.find_dashboard_info |
There was a problem hiding this comment.
Good logic here to try and update dashboard but not necessary, can be deleted
MelTravelz
requested changes
Oct 22, 2023
MelTravelz
changed the title
api/v1/users/:id/loans/:id
MelTravelz
approved these changes
Oct 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
This is related to #33
This closes #33
[x] I linted my work. (RuboCop)
[] I've updated documentation & README. (if necessary)
(For Fun!) Please include a link to a meme/gif of your feelings about this branch!
Link: