Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy WallGoDefaults #243

Merged
merged 5 commits into from
Sep 12, 2024
Merged

Tidy WallGoDefaults #243

merged 5 commits into from
Sep 12, 2024

Conversation

jorindevandevis
Copy link
Collaborator

This is just a small PR:

  • Removed some trailing whitespaces and split some lines that were too long
  • Wrote EquationOfMotion instead of EOM
  • Moved the default values of the relative and absolute error tolerance of hydrodynamics into the default config file, instead of the class itself.

@jorindevandevis jorindevandevis requested review from benoitlaurent96 and removed request for AndreasEkstedt September 6, 2024 09:21
benoitlaurent96
benoitlaurent96 approved these changes Sep 10, 2024
View reviewed changes
Copy link
Collaborator

@benoitlaurent96 benoitlaurent96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me, you can merge it!

@jorindevandevis jorindevandevis merged commit 0968020 into main Sep 12, 2024
1 check passed
@jorindevandevis jorindevandevis deleted the tidyWallGoDefaults branch September 12, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitlaurent96 benoitlaurent96 benoitlaurent96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jorindevandevis @benoitlaurent96 @joonashir