Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shutdown cluster cleanly when SIGTERM or SIGINT is received #1705

Merged
merged 1 commit into from
Nov 7, 2017
Merged

Shutdown cluster cleanly when SIGTERM or SIGINT is received #1705

merged 1 commit into from
Nov 7, 2017

Commits on Nov 7, 2017

  1. Shutdown cluster cleanly when SIGTERM or SIGINT is received 

    Previously, if a developer working with Wallaroo sent a SIGINT via
ctrl-c in the terminal, Wallaroo would exit but wouldn't gracefully
shutdown. This could lead to errors on the next application startup as
recovery files weren't dispose of properly.

With this commit, sending SIGTERM or SIGINT will shut down Wallaroo
gracefully in the same fashion that the external "shutdown cluster"
command work.

Once we have "shrink to fit" in place, the plan would be to have SIGTERM
and SIGINT remove that individual worker from the cluster rathter than
shut the entire cluster down. Once we have shrink to fit in place, we
might change our mind and go in a different direction and leave this
functionality as is.

Closes #1701
    @SeanTAllen
    SeanTAllen committed Nov 7, 2017
    Configuration menu
    Copy the full SHA
    8b52a68 View commit details
    Browse the repository at this point in the history