Ensure that new sources don't try to connect to old workers #2004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtfmumm
force-pushed
the
shrink_reconnect
branch
from
07877cb
to
8404e71
Compare
This was caused by two issues: 1) When a DataReceiver was disposed (when a worker leaves the cluster, it calls dispose() on all DataReceivers), it wasn't telling its corresponding Boundary that it's out for good. So the Boundary kept trying to reconnect. 2) When new sources connected after a shrink, they were given outdated boundary builders. This led them to try to connect to workers that were no longer part of the cluster. This commit fixes both. Closes #2001
jtfmumm
force-pushed
the
shrink_reconnect
branch
from
8404e71
to
a259b2c
Compare
wallaroolabs-wally
added a commit
that referenced
this pull request
Jan 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was caused by two issues:
When a DataReceiver was disposed (when a worker leaves the
cluster, it calls dispose() on all DataReceivers), it wasn't
telling its corresponding Boundary that it's out for good.
So the Boundary kept trying to reconnect.
When new sources connected after a shrink, they were given
outdated boundary builders. This led them to try to connect
to workers that were no longer part of the cluster.
This commit fixes both.
Closes #2001