-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Verify v2 #1464
Merged
Merged
feat: Verify v2 #1464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nV2 into feat/verify_v2
chris13524
reviewed
Aug 5, 2024
core/android/src/main/kotlin/com/walletconnect/android/verify/client/VerifyClient.kt
Outdated
Show resolved
Hide resolved
chris13524
reviewed
Aug 5, 2024
core/android/src/main/kotlin/com/walletconnect/android/verify/domain/VerifyRepository.kt
Outdated
Show resolved
Hide resolved
…nV2 into feat/verify_v2 # Conflicts: # foundation/src/main/kotlin/com/walletconnect/foundation/network/BaseRelayClient.kt
…nV2 into feat/verify_v2 # Conflicts: # .gitignore
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sample Debug Kotlin Wallet with Verify V2: https://appdistribution.firebase.google.com/testerapps/1:1056012215045:android:e94d26b8752f3d5c11cd6c/releases/5mvfdg5qn8328?utm_source=firebase-console
Sample JS Dapp with Verify V2: https://react-dapp-v2-git-chore-verify-v2-samples-walletconnect1.vercel.app/
@chris13524 please test on your side as well before it's merged 🙏